Propagate correct data to the Toolbar servers

chrome/browser/autofill/autofill_manager.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_manager.h"
 
 #include <limits>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 466 matching lines @@
 
   return prefs->GetBoolean(prefs::kAutoFillEnabled);
 }
 
 void AutoFillManager::DeterminePossibleFieldTypesForUpload(
     FormStructure* submitted_form) {
   for (size_t i = 0; i < submitted_form->field_count(); i++) {
     const AutoFillField* field = submitted_form->field(i);
     FieldTypeSet field_types;
     personal_data_->GetPossibleFieldTypes(field->value(), &field_types);
+
     DCHECK(!field_types.empty());

[Ilya Sherman, 2011/01/21 00:25:58]

What happened to this bit of code?

if (field_types.size() > 1) {
       // If there is more than one possibility, do not poison the crowd-sourced
       // data by returning UNKNOWN_TYPE.
       field_types.clear();
       field_types.insert(UNKNOWN_TYPE);
}

[GeorgeY, 2011/01/21 00:39:02]

Do not want to bloat this cl too much, going to to that in separate cl, as your
metrics tests need to be adjusted with that change

[Ilya Sherman, 2011/01/21 00:46:51]

If we want to make the changes separately, we should make that change first, so
as to not pollute the server data.

With the logging code split out from this method though, there shouldn't need to
be updates to the metrics test -- or am I missing something?

[dhollowa, 2011/01/21 02:14:57]

Ilya is correct.  I wrote a "Washington Irving" unit test and am getting
incorrect results.  Please see: http://codereview.chromium.org/6373007 for
details.

However, I would argue that we continue to set the full list of possible types
here, but modify the xml formatting code to interpret multiple values as
UNKNOWN.  This code should not know the details of how xml is generated and
precompute those results.

On 2011/01/21 00:46:51, Ilya Sherman wrote:

[GeorgeY, 2011/01/21 03:41:32]

Done.

     submitted_form->set_possible_types(i, field_types);
   }
 }
 
 void AutoFillManager::LogMetricsAboutSubmittedForm(
     const FormData& form,
     const FormStructure* submitted_form) {
   FormStructure* cached_submitted_form = NULL;
   AutoFillField* ignored;
   if (!FindCachedFormAndField(form, form.fields.front(),
@@ skipping 388 matching lines @@
     return std::string();
 
   std::map<int, std::string>::const_iterator iter = id_guid_map_.find(id);
   if (iter == id_guid_map_.end()) {
     NOTREACHED();
     return std::string();
   }
 
   return iter->second;
 }