disable field trials if the build is 30 days or older

net/disk_cache/backend_impl.cc

Index: net/disk_cache/backend_impl.cc
===================================================================
--- net/disk_cache/backend_impl.cc	(revision 70854)
+++ net/disk_cache/backend_impl.cc	(working copy)
@@ -182,7 +182,8 @@
   scoped_refptr<base::FieldTrial> trial2(
       new base::FieldTrial("CacheThrottle", 100));
   int group2a = trial2->AppendGroup("CacheThrottle_On", 10);  // 10 % in.
-  trial2->AppendGroup("CacheThrottle_Off", 10);  // 10 % control.
+  trial2->AppendGroup("CacheThrottle_Off",
+      base::FieldTrial::kAllRemainingProbability);  // 90 % control.

[rvargas (doing something else), 2011/01/12 19:25:14]

This is not the same. The experiment has a control group, otherwise it is not
possible to really make any assertion about what's going on with the profiles
that are part of the experiment.

Why the need to have an extra group with all remaining users? It seems that it
only adds overhead (+ noise) everywhere.

[jar (doing other things), 2011/01/13 00:04:56]

As per our discussion....

We need some way to establish what a "reasonable" default would be.  The current
hack is to use the "all remaining probability" group to signal that.  Raman may
end up formalizing this in the constructor (as a new argument set), and that may
allow us to effectively reduce or turn-off trials under a variety of conditions
(old trials? reduce trial sets in Stable and beta?).  

To start any of this, we need a clear understanding of a "default" thing to do
when we effectively disable a trial.

On 2011/01/12 19:25:14, rvargas wrote:

 
   return trial2->group() == group2a;
 }