Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 62127: Basic underpinnings of the gyp equivalent of the Linux SHARED=1 build:... (Closed)

Created:
11 years, 8 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, Craig Schlenter
Visibility:
Public.

Description

Basic underpinnings of the gyp equivalent of the Linux SHARED=1 build: parameterize the 'type' setting of the various library targets, with a default of 'static_library'. (Hat tip to Craig Schlenter.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -49 lines) Patch
M base/base.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M build/common.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M build/temp_gyp/breakpad.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M build/temp_gyp/googleurl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/temp_gyp/v8.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome.gyp View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/util.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/hunspell/hunspell.gyp View 1 chunk +1 line, -1 line 0 comments Download
M google_update/google_update.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/printing.gyp View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/sandbox.gyp View 1 chunk +1 line, -1 line 0 comments Download
M sdch/sdch.gyp View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 1 chunk +1 line, -1 line 0 comments Download
M testing/gtest.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/bzip2/bzip2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz/harfbuzz.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libevent/libevent.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjpeg/libjpeg.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libpng/libpng.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxml/libxml.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libxslt/libxslt.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/modp_b64/modp_b64.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/zlib.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/activex_shim/activex_shim.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/default_plugin.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
11 years, 8 months ago (2009-04-07 23:28:24 UTC) #1
Mark Mentovai
11 years, 8 months ago (2009-04-08 01:08:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698