Issue 62123: Skia: remove fHeight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62123: Skia: remove fHeight (Closed)

Created:
11 years, 8 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Skia: remove fHeight Skia was previously calculating the leading value incorrectly, leading us to add fHeight to get the height of a line of text. Now that Skia is calculating fLeading correctly, we can remove fHeight.

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -10 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/include/SkPaint.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	skia/ports/SkFontHost_FreeType.cpp	View	5 chunks	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 8 months ago (2009-04-07 22:53:38 UTC) #2

rubber stamp after you make the array decls smaller too

Expand Messages | Collapse Messages