Issue 6211002: Don't create a WebDataService in AutoFillManagerTest tests, since that object...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6211002: Don't create a WebDataService in AutoFillManagerTest tests, since that object... (Closed)

Created:
9 years, 11 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, Ilya Sherman, dhollowa, James Hawkins, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't create a WebDataService in AutoFillManagerTest tests, since that object is hard to clean up correctly in unit tests because of all the PostTasking it does. Just make AutoCompleteHistoryManager handle a null WebDataService. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70955

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	chrome/browser/autocomplete_history_manager.cc	View		3 chunks	+9 lines, -5 lines	0 comments	Download
	M	chrome/browser/autofill/autofill_manager_unittest.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

9 years, 11 months ago (2011-01-10 22:15:34 UTC) #2

LGTM, thanks for looking into this!

Expand Messages | Collapse Messages