Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 6211001: metrics: Send ability to notify chrome of system crashes (Closed)

Created:
9 years, 11 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa
Visibility:
Public.

Description

metrics: Send ability to notify chrome of system crashes Change-Id: I11df903c020141a8123055620f9ad23fedc06c7d BUG=9352 TEST= 1) UserCrash 2) Crash random process and verify Chrome indicates "other user" crashes occurred in its stability UMA data. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5abd00c

Patch Set 1 #

Patch Set 2 : respond to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M c_metrics_library.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M c_metrics_library.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M metrics_library.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M metrics_library.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M metrics_library_test.cc View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kmixter1
9 years, 11 months ago (2011-01-08 02:09:08 UTC) #1
petkov
9 years, 11 months ago (2011-01-10 18:50:22 UTC) #2
LGTM (you need to sync/rebase though)

Powered by Google App Engine
This is Rietveld 408576698