Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 62102: Fix profiling on Android. (Closed)

Created:
11 years, 8 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix profiling on Android. Committed: http://code.google.com/p/v8/source/detail?r=1685

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M src/platform-linux.cc View 1 2 chunks +27 lines, -3 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Erik Corry
11 years, 8 months ago (2009-04-07 13:05:55 UTC) #1
Kasper Lund
http://codereview.chromium.org/62102/diff/1/2 File src/platform-linux.cc (right): http://codereview.chromium.org/62102/diff/1/2#newcode565 Line 565: unsigned long arm_cpsr; This looks fairly ARM specific. ...
11 years, 8 months ago (2009-04-07 13:08:33 UTC) #2
Dean McNamee
http://codereview.chromium.org/62102/diff/1/2 File src/platform-linux.cc (right): http://codereview.chromium.org/62102/diff/1/2#newcode557 Line 557: // Android runs a fairly new Linux kernel, ...
11 years, 8 months ago (2009-04-07 13:12:50 UTC) #3
Kasper Lund
11 years, 8 months ago (2009-04-07 13:32:08 UTC) #4
LGTM, but

http://codereview.chromium.org/62102/diff/1003/6
File src/platform-linux.cc (right):

http://codereview.chromium.org/62102/diff/1003/6#newcode556
Line 556: #if !defined(__GLIBC__) && defined(__arm__)
How about __thumb__ ?

Powered by Google App Engine
This is Rietveld 408576698