Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 62099: Fix a problem with DrawRectInt at the edges of a ChromeCanvas. (Closed)

Created:
11 years, 8 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a problem with DrawRectInt at the edges of a ChromeCanvas. It seems there used to be an old bug in Skia, and we explicitly set a stroke width of 1 instead of 0 to work around it. Internally in Skia this goes down a more complex path, creating a path from the rect, and then filling the path. This was causing problems at the edges of the canvas, for example if you were to DrawRectInt(0, 0, width - 1, height - 1). Switch some SkRects to SkIRects. Internally Skia will still convert them to scalars, but it makes our code a bit cleaner.

Patch Set 1 #

Patch Set 2 : Typo #

Patch Set 3 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/common/gfx/chrome_canvas.cc View 1 2 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dean McNamee
gnarlz man.
11 years, 8 months ago (2009-04-07 11:03:20 UTC) #1
sky
11 years, 8 months ago (2009-04-07 16:04:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698