Fix IndexedDB race condition during shutdown.

chrome/browser/in_process_webkit/indexed_db_key_utility_client.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/in_process_webkit/indexed_db_key_utility_client.h"
 
 #include <vector>
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/common/indexed_db_key.h"
 #include "chrome/common/serialized_script_value.h"
 
+IndexedDBKeyUtilityClient* IndexedDBKeyUtilityClient::Get() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
+  AutoLock auto_lock(instantiation_lock_);
+
+  if (!instance_.get()) {
+    instance_ = new IndexedDBKeyUtilityClient();
+    instance_->StartUtilityProcess();
+  }
+
+  return instance_.get();
+}
+
+void IndexedDBKeyUtilityClient::Shutdown() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+  AutoLock autolock(instantiation_lock_);
+
+  if (!instance_.get())
+    return;
+
+  instance_->utility_process_host_->EndBatchMode();
+  instance_->utility_process_host_ = NULL;
+  instance_->client_ = NULL;
+  instance_->state_ = STATE_SHUTDOWN;
+  instance_ = NULL;
+}
+
 IndexedDBKeyUtilityClient::IndexedDBKeyUtilityClient()
     : waitable_event_(false, false),
       state_(STATE_UNINITIALIZED),
       utility_process_host_(NULL) {
 }
 
 IndexedDBKeyUtilityClient::~IndexedDBKeyUtilityClient() {
   DCHECK(state_ == STATE_UNINITIALIZED || state_ == STATE_SHUTDOWN);
   DCHECK(!utility_process_host_);
   DCHECK(!client_.get());
 }
 
 void IndexedDBKeyUtilityClient::StartUtilityProcess() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
   DCHECK(state_ == STATE_UNINITIALIZED);
 
   GetRDHAndStartUtilityProcess();
   bool ret = waitable_event_.Wait();
 
   DCHECK(ret && state_ == STATE_INITIALIZED);
 }
 
-void IndexedDBKeyUtilityClient::EndUtilityProcess() {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
-  DCHECK(state_ == STATE_INITIALIZED);
-
-  EndUtilityProcessInternal();
-  bool ret = waitable_event_.Wait();
-
-  DCHECK(ret && state_ == STATE_SHUTDOWN);
-}
-
 void IndexedDBKeyUtilityClient::CreateIDBKeysFromSerializedValuesAndKeyPath(
     const std::vector<SerializedScriptValue>& values,
     const string16& key_path,
     std::vector<IndexedDBKey>* keys) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT));
+  if (state_ == STATE_SHUTDOWN) {
+    keys->clear();
+    return;
+  }
+
   DCHECK(state_ == STATE_INITIALIZED);
 
   state_ = STATE_CREATING_KEYS;
   CallStartIDBKeyFromValueAndKeyPathFromIOThread(values, key_path);
   bool ret = waitable_event_.Wait();
   DCHECK(ret && state_ == STATE_INITIALIZED);
 
   *keys = keys_;
 }
 
@@ skipping 97 matching lines @@
 void IndexedDBKeyUtilityClient::Client::OnIDBKeysFromValuesAndKeyPathSucceeded(
     int id, const std::vector<IndexedDBKey>& keys) {
   parent_->SetKeys(keys);
   parent_->FinishCreatingKeys();
 }
 
 void IndexedDBKeyUtilityClient::Client::OnIDBKeysFromValuesAndKeyPathFailed(
     int id) {
   parent_->FinishCreatingKeys();
 }
+
+scoped_refptr<IndexedDBKeyUtilityClient> IndexedDBKeyUtilityClient::instance_;
+base::Lock IndexedDBKeyUtilityClient::instantiation_lock_;