Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2182)

Unified Diff: chrome/browser/ui/gtk/bookmark_bar_gtk.cc

Issue 6209001: Change DCHECK in BookmarkBarGtk to DLOG and return. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: improve Observe() check, revert CreateAllBookmarkButtons to DCHECK Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/bookmark_bar_gtk.cc
diff --git a/chrome/browser/ui/gtk/bookmark_bar_gtk.cc b/chrome/browser/ui/gtk/bookmark_bar_gtk.cc
index a54172cd8125fc06dc26406335b9f046f0d2a12f..9ff2bf9bda9932d1876a25155c3c95b55b292d59 100644
--- a/chrome/browser/ui/gtk/bookmark_bar_gtk.cc
+++ b/chrome/browser/ui/gtk/bookmark_bar_gtk.cc
@@ -805,14 +805,11 @@ void BookmarkBarGtk::Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
if (type == NotificationType::BROWSER_THEME_CHANGED) {
- if (model_) {
+ if (model_ && model_->IsLoaded()) {
// Regenerate the bookmark bar with all new objects with their theme
// properties set correctly for the new theme.
RemoveAllBookmarkButtons();
CreateAllBookmarkButtons();
- } else {
- DLOG(ERROR) << "Received a theme change notification while we "
- << "don't have a BookmarkModel. Taking no action.";
}
UpdateEventBoxPaintability();

Powered by Google App Engine
This is Rietveld 408576698