Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 6208004: Fix PartScrollbarHoriztonalTrack typo now that we've rolled to pick up... (Closed)

Created:
9 years, 11 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix PartScrollbarHoriztonalTrack typo now that we've rolled to pick up http://trac.webkit.org/changeset/75292. BUG=none TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webkit/glue/webthemeengine_impl_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mihai Parparita -not on Chrome
9 years, 11 months ago (2011-01-11 22:42:49 UTC) #1
darin (slow to review)
9 years, 11 months ago (2011-01-12 21:57:41 UTC) #2
LGTM

On Tue, Jan 11, 2011 at 2:42 PM, <mihaip@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Fix PartScrollbarHoriztonalTrack typo now that we've rolled to pick up
> http://trac.webkit.org/changeset/75292.
>
> BUG=none
> TEST=trybot
>
> Please review this at http://codereview.chromium.org/6208004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     webkit/glue/webthemeengine_impl_linux.cc
>
>
> Index: webkit/glue/webthemeengine_impl_linux.cc
> ===================================================================
> --- webkit/glue/webthemeengine_impl_linux.cc    (revision 71052)
> +++ webkit/glue/webthemeengine_impl_linux.cc    (working copy)
> @@ -34,7 +34,7 @@
>       return gfx::NativeThemeLinux::kScrollbarHorizontalThumb;
>     case WebKit::WebThemeEngine::PartScrollbarVerticalThumb:
>       return gfx::NativeThemeLinux::kScrollbarVerticalThumb;
> -    case WebKit::WebThemeEngine::PartScrollbarHoriztonalTrack:
> +    case WebKit::WebThemeEngine::PartScrollbarHorizontalTrack:
>       return gfx::NativeThemeLinux::kScrollbarHorizontalTrack;
>     case WebKit::WebThemeEngine::PartScrollbarVerticalTrack:
>       return gfx::NativeThemeLinux::kScrollbarVerticalTrack;
> @@ -64,7 +64,7 @@
>     WebKit::WebThemeEngine::State state,
>     const WebKit::WebThemeEngine::ExtraParams* extra_params,
>     gfx::NativeThemeLinux::ExtraParams* native_theme_extra_params) {
> -  if (part == WebKit::WebThemeEngine::PartScrollbarHoriztonalTrack ||
> +  if (part == WebKit::WebThemeEngine::PartScrollbarHorizontalTrack ||
>       part == WebKit::WebThemeEngine::PartScrollbarVerticalTrack) {
>     native_theme_extra_params->scrollbar_track.track_x =
>         extra_params->scrollbarTrack.trackX;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698