Clarify wording around blocking 3rd party cookies and add lab to block reading of 3rd party cookies

net/base/static_cookie_policy.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_STATIC_COOKIE_POLICY_H_
 #define NET_BASE_STATIC_COOKIE_POLICY_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "net/base/cookie_policy.h"
 
 class GURL;
 
 namespace net {
 
 // The StaticCookiePolicy class implements a static cookie policy that supports
 // three modes: allow all, deny all, or block third-party cookies.
 //
 // NOTE: This CookiePolicy implementation always completes synchronously.  The
 // callback parameter will be ignored if specified.  Just pass NULL.
 //
 class StaticCookiePolicy : public CookiePolicy {
  public:
+  // Do not change the order of these types as they are persisted in
+  // preferences.
   enum Type {
-    ALLOW_ALL_COOKIES = 0,      // Do not perform any cookie blocking.
-    BLOCK_THIRD_PARTY_COOKIES,  // Prevent third-party cookies from being set.
-    BLOCK_ALL_COOKIES           // Disable cookies.
+    // Do not perform any cookie blocking.
+    ALLOW_ALL_COOKIES = 0,
+    // Prevent third-party cookies from being set.
+    BLOCK_SETTING_THIRD_PARTY_COOKIES,
+    // Disable cookies.
+    BLOCK_ALL_COOKIES,
+    // Prevent third-party cookies from being set or read.
+    BLOCK_ALL_THIRD_PARTY_COOKIES

[Randy Smith (Not in Mondays), 2011/01/11 18:38:42]

This section seems a bit awkward to me; the combination of the ordering (which I
understand is enforced for versioning purposes) and the block all cookies
comment being very short makes this a bit confusing.  Maybe change "Disable
cookies." to "Disable all cookies (third party or not) from being set or read."?

   };
 
   StaticCookiePolicy()
       : type_(StaticCookiePolicy::ALLOW_ALL_COOKIES) {
   }
 
   explicit StaticCookiePolicy(Type type)
       : type_(type) {
   }
 
@@ skipping 19 matching lines @@
 
  private:
   Type type_;
 
   DISALLOW_COPY_AND_ASSIGN(StaticCookiePolicy);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_STATIC_COOKIE_POLICY_H_