Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 6207005: Clarify wording around blocking 3rd party cookies and add lab to block reading of 3rd party cookies (Closed)

Created:
9 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Clarify wording around blocking 3rd party cookies and add lab to block reading of 3rd party cookies BUG=69066 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71148

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -16 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_cookie_policy.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_cookie_policy.cc View 4 chunks +10 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/static_cookie_policy.h View 1 chunk +10 lines, -3 lines 1 comment Download
M net/base/static_cookie_policy.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M net/base/static_cookie_policy_unittest.cc View 2 chunks +18 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
please review
9 years, 11 months ago (2011-01-11 09:36:23 UTC) #1
Randy Smith (Not in Mondays)
LGTM, with the one suggestion below (which you're welcome to use your own judgment on). ...
9 years, 11 months ago (2011-01-11 18:38:42 UTC) #2
jochen (gone - plz use gerrit)
9 years, 11 months ago (2011-01-11 20:57:54 UTC) #3
On 2011/01/11 18:38:42, rdsmith wrote:
> LGTM, with the one suggestion below (which you're welcome to use your own
> judgment on).
> 
> One question, which shows my ignorance, but might end it: What exactly are
third
> party cookies?

third-party refers to the context in which the cookie is used, e.g. if you go to
www.example.com that includes data from somewhere.org in e.g. an iframe, then a
cookie on example.com is a first-party cookie while a cookie for somewhere.org
would be a third-party cookie.

If you go, however, directly to somewhere.org its cookies are suddenly
first-party cookies.

Powered by Google App Engine
This is Rietveld 408576698