Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 6207002: Fixed bug 64847: Graphics2D paints outside plugin boundaries. (Closed)

Created:
9 years, 11 months ago by ddorwin
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fixed bug 64847: Graphics2D paints outside plugin boundaries. Also removed unused |origin| variables. BUG=64847 TEST=Modify the first condition in example.cc::MyInstance::DidChangeView() to use "<=" instead of "==". On the example page, use the Toggle Size button to make the plugin larger then smaller. The plugin should not paint outside its boundary. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M chrome/renderer/webplugin_delegate_pepper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 3 chunks +30 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ddorwin
9 years, 11 months ago (2011-01-12 02:36:48 UTC) #1
brettw
9 years, 11 months ago (2011-01-12 07:01:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698