Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: media/filters/ffmpeg_video_decoder_unittest.cc

Issue 6206001: Merge 70669 - Don't uninitialize FFmpegVideoDecodeEngine if we haven't initia... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/597/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_video_decoder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_video_decoder_unittest.cc
===================================================================
--- media/filters/ffmpeg_video_decoder_unittest.cc (revision 70815)
+++ media/filters/ffmpeg_video_decoder_unittest.cc (working copy)
@@ -160,12 +160,15 @@
}
virtual ~FFmpegVideoDecoderTest() {
- // We had to set this because not all tests had initialized the engine.
- engine_->event_handler_ = decoder_.get();
EXPECT_CALL(callback_, OnFilterCallback());
EXPECT_CALL(callback_, OnCallbackDestroyed());
- EXPECT_CALL(*engine_, Uninitialize())
- .WillOnce(EngineUninitialize(engine_));
+
+ // The presence of an event handler means we need to uninitialize.
+ if (engine_->event_handler_) {
+ EXPECT_CALL(*engine_, Uninitialize())
+ .WillOnce(EngineUninitialize(engine_));
+ }
+
decoder_->Stop(callback_.NewCallback());
// Finish up any remaining tasks.
« no previous file with comments | « media/filters/ffmpeg_video_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698