Issue 62050: DevTools: add basic console support.

Issue 62050: DevTools: add basic console support. (Closed)

Created:
11 years, 8 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: add basic console support. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13240

Patch Set 8 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -37 lines)			Patch
M	webkit/glue/chrome_client_impl.cc	View	1 2 3 4	2 chunks	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools.js	View	1 2 3 4	3 chunks	+53 lines, -35 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools_host_stub.js	View	1 2 3 4	2 chunks	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/js/inspector_controller_impl.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/tools_agent.h	View	1 2 3 4 5	2 chunks	+9 lines, -2 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.h	View	1 2 3 4 5 6 7	4 chunks	+17 lines, -0 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.cc	View	2 3 4 6 7	4 chunks	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

On 2009/04/06 11:06:43, pfeldman wrote: > Please look at this (I updated the change)!

11 years, 8 months ago (2009-04-06 14:09:58 UTC) #2

yurys

LGTM http://codereview.chromium.org/62050/diff/1001/17 File webkit/glue/webdevtoolsagent_impl.cc (right): http://codereview.chromium.org/62050/diff/1001/17#newcode121 Line 121: if (!attached_) { would be nice to ...

11 years, 8 months ago (2009-04-06 15:09:49 UTC) #3

pfeldman

http://codereview.chromium.org/62050/diff/1001/17 File webkit/glue/webdevtoolsagent_impl.cc (right): http://codereview.chromium.org/62050/diff/1001/17#newcode121 Line 121: if (!attached_) { On 2009/04/06 15:09:49, Yury Semikhatsky ...

11 years, 8 months ago (2009-04-07 07:26:47 UTC) #4

yurys

LGTM http://codereview.chromium.org/62050/diff/30/1026 File webkit/glue/webdevtoolsagent_impl.cc (right): http://codereview.chromium.org/62050/diff/30/1026#newcode138 Line 138: // Batch shifts to save ticks. wrong ...

11 years, 8 months ago (2009-04-07 08:58:54 UTC) #5

pfeldman

11 years, 8 months ago (2009-04-07 09:03:11 UTC) #6

http://codereview.chromium.org/62050/diff/30/1026
File webkit/glue/webdevtoolsagent_impl.cc (right):

http://codereview.chromium.org/62050/diff/30/1026#newcode138
Line 138: // Batch shifts to save ticks.
On 2009/04/07 08:58:54, Yury Semikhatsky wrote:
> wrong alignment

Done.

Expand Messages | Collapse Messages