Issue 62045: Switching windows over to gyp generated googleurl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62045: Switching windows over to gyp generated googleurl. (Closed)

Created:
11 years, 8 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Switching windows over to gyp generated googleurl. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13138

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	build/all.gyp	View		2 chunks	+1 line, -1 line	1 comment	Download
M	chrome/chrome.sln	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/webkit.sln	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 8 months ago (2009-04-05 20:17:26 UTC) #2

Would it make sense to move this gyp file to the googleurl repo?

but LGTM for now

http://codereview.chromium.org/62045/diff/9/1005
File build/all.gyp (right):

http://codereview.chromium.org/62045/diff/9/1005#newcode40
Line 40: 'temp_gyp/googleurl.gyp:*',
Why is it "temp_gyp" ?

Expand Messages | Collapse Messages