Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 62043: The bookmarks title in the bubble should be left justified (Closed)

Created:
11 years, 8 months ago by Mohamed Mansour (USE mhm)
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

The bookmarks title in the bubble should be left justified Since the Selection was from LEFT to RIGHT, it does seem like its left justified, we change the selection to be reversed, that way it will appear as left justified. BUG=9393 ( http://crbug.com/9393 )

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/views/controls/text_field.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
Mohamed Mansour (USE mhm)
Added sky as a reviewer cause he is most familiar with bookmarks and touched this ...
11 years, 8 months ago (2009-04-05 17:45:06 UTC) #1
sky
http://codereview.chromium.org/62043/diff/1/2 File chrome/views/controls/text_field.cc (right): http://codereview.chromium.org/62043/diff/1/2#newcode348 Line 348: SetSel(GetTextLength(), 0); Does this mean any time the ...
11 years, 8 months ago (2009-04-06 16:35:45 UTC) #2
Mohamed Mansour (USE mhm)
http://codereview.chromium.org/62043/diff/1/2 File chrome/views/controls/text_field.cc (right): http://codereview.chromium.org/62043/diff/1/2#newcode348 Line 348: SetSel(GetTextLength(), 0); On 2009/04/06 16:35:46, sky wrote: > ...
11 years, 8 months ago (2009-04-06 16:45:23 UTC) #3
sky
Yes, LGTM.
11 years, 8 months ago (2009-04-06 17:53:15 UTC) #4
sky
Landed in r13177. Thanks!
11 years, 8 months ago (2009-04-06 19:52:16 UTC) #5
Mohamed Mansour (USE mhm)
11 years, 8 months ago (2009-04-09 17:22:23 UTC) #6
On 2009/04/06 19:52:16, sky wrote:
> Landed in r13177.
> Thanks!

Thanks :) Please close this review, only committers could close it :)

Powered by Google App Engine
This is Rietveld 408576698