chrome/browser/ui/browser.h - Issue 6203006: Attempt at fixing crash in ProcessPendingTabs. With the current code,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.h

Issue 6203006: Attempt at fixing crash in ProcessPendingTabs. With the current code, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Better comments Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.h

diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h

index 16b0aba7ae843944859c9eaaa15332d89266c647..b139e6324e9459887754cac43209f7d417691414 100644

--- a/chrome/browser/ui/browser.h

+++ b/chrome/browser/ui/browser.h

@@ -909,8 +909,10 @@ class Browser : public TabHandlerDelegate,

// Cleans up state appropriately when we are trying to close the browser and

// the tab has finished firing its unload handler. We also use this in the

// cases where a tab crashes or hangs even if the beforeunload/unload haven't

- // successfully fired.

- void ClearUnloadState(TabContents* tab);

+ // successfully fired. If |process_now| is true |ProcessPendingTabs| is

+ // invoked immediately, otherwise it is invoked after a delay (PostTask).

+ // Typically you'll want to pass in true for |process_now|.

brettw 2011/01/13 06:42:16 It might be nice if this mentioned why you might w

+ void ClearUnloadState(TabContents* tab, bool process_now);

// In-progress download termination handling /////////////////////////////////

« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »