Issue 6203005: WebDragSource: Added a guard for null [contentView_ window]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6203005: WebDragSource: Added a guard for null [contentView_ window] (Closed)

Created:
9 years, 11 months ago by gmorrita

Modified:
9 years, 7 months ago

Reviewers:
jianli

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

WebDragSource: Added a guard for null [contentView_ window] BUG=69095 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71416

Patch Set 2 : Addressed the feedback #

Patch Set 3 : The last patch is broken. Fixed. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/web_drag_source.mm	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jianli

http://codereview.chromium.org/6203005/diff/1/chrome/browser/ui/cocoa/web_drag_source.mm File chrome/browser/ui/cocoa/web_drag_source.mm (right): http://codereview.chromium.org/6203005/diff/1/chrome/browser/ui/cocoa/web_drag_source.mm#newcode7 chrome/browser/ui/cocoa/web_drag_source.mm:7: #include <limits> Why is this include needed in this ...

9 years, 11 months ago (2011-01-12 21:32:27 UTC) #2

gmorrita

The last patch doesn't work because it lacks DragSourceEndedAt() call... I fixed it. Could you ...

9 years, 11 months ago (2011-01-13 08:34:43 UTC) #3

LGTM.