Issue 6203004: DOMUI: Stub out List.activateItemAtIndex for lists that don't implement this

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6203004: DOMUI: Stub out List.activateItemAtIndex for lists that don't implement this (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
csilv, arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Stub out List.activateItemAtIndex for lists that don't implement this method. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71128

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/resources/shared/js/cr/ui/list.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

9 years, 11 months ago (2011-01-12 02:32:11 UTC) #4

LGTM

erik



On Tue, Jan 11, 2011 at 16:56,  <jhawkins@chromium.org> wrote:
> Reviewers: arv,
>
> Description:
> DOMUI: Stub out List.activateItemAtIndex for lists that don't implement this
> method.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/6203004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/resources/shared/js/cr/ui/list.js
>
>
> Index: chrome/browser/resources/shared/js/cr/ui/list.js
> diff --git a/chrome/browser/resources/shared/js/cr/ui/list.js
> b/chrome/browser/resources/shared/js/cr/ui/list.js
> index
>
6fbe1cce845d03ebb90c21dc00a833f521360bbd..ba1da003980f76ffe81acf3a0355f3e0699bcf72
> 100644
> --- a/chrome/browser/resources/shared/js/cr/ui/list.js
> +++ b/chrome/browser/resources/shared/js/cr/ui/list.js
> @@ -608,6 +608,14 @@ cr.define('cr.ui', function() {
>         this.redraw();
>       }
>     },
> +
> +    /**
> +     * Called when a list item is activated, currently only by a double
> click
> +     * event.
> +     * @param {number} index The index of the activated item.
> +     */
> +    activateItemAtIndex: function(index) {
> +    },
>   };
>
>   cr.defineProperty(List, 'disabled', cr.PropertyKind.BOOL_ATTR);
>
>
>

Expand Messages | Collapse Messages