Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 6201006: X64 Crankshaft: Ported lots of boilerplate code. (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
William Hesse, Rico
CC:
v8-dev
Visibility:
Public.

Description

X64 Crankshaft: Ported lots of boilerplate code. Small tweaks to make X64 compliant. A few UNIMPLEMENTED left, but most empty functions call Abort to bail out.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments. Updated to match newest ia32 version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4066 lines, -181 lines) Patch
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/assembler-x64.h View 3 chunks +19 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 5 chunks +87 lines, -45 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 3 chunks +1033 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.h View 1 9 chunks +1744 lines, -121 lines 0 comments Download
M src/x64/lithium-x64.cc View 4 chunks +1169 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein
9 years, 11 months ago (2011-01-12 14:18:49 UTC) #1
William Hesse
LGTM.
9 years, 11 months ago (2011-01-12 14:54:09 UTC) #2
Rico
LGTM This is a lot of code to review without knowing which part in particular ...
9 years, 11 months ago (2011-01-12 20:06:25 UTC) #3
Rico
LGTM, we should probably update it to be exactly consistent with ia32 specific files before ...
9 years, 11 months ago (2011-01-13 09:11:58 UTC) #4
Lasse Reichstein
9 years, 11 months ago (2011-01-13 09:30:20 UTC) #5

          

Powered by Google App Engine
This is Rietveld 408576698