chrome/test/data/extensions/api_test/isolated_apps/app1/manifest.json - Issue 6201005: Initial support for partitioning cookies for isolated apps.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/isolated_apps/app1/manifest.json

Issue 6201005: Initial support for partitioning cookies for isolated apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add ChromeURLRequestContext::Copy. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/profiles/profile_impl.cc ('K') | « chrome/test/data/extensions/api_test/isolated_apps/app1/main.html ('k') | chrome/test/data/extensions/api_test/isolated_apps/app2/main.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "isolated_app1",

	3 "version": "0.1",

	4 "description": "Tests isolation of stored data for apps.",

	5 "app": {

	6 "urls": [

	7 "http://localhost/files/extensions/api_test/isolated_apps/app1"

	8 ],

	9 "launch": {

	10 "web_url": "http://localhost:1337/files/extensions/api_test/isolated_apps/ app1/main.html"
	Paweł Hajdan Jr. 2011/03/03 15:50:30 Do not hardcode testserver URLs, it's going to bre Do not hardcode testserver URLs, it's going to break! Please read the net/test/test_server.h header. Charlie Reis 2011/03/03 18:20:12 I was following what app_process did: http://src.c Show quoted text On 2011/03/03 15:50:30, Paweł Hajdan Jr. wrote: > Do not hardcode testserver URLs, it's going to break! Please read the > net/test/test_server.h header. I was following what app_process did: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/a... The problem is that this is a static JSON file, so I can't just call TestServer::GetURL. Do we have any placeholder replacement logic for JSON files in tests? Paweł Hajdan Jr. 2011/03/03 18:24:09 Oh, it seems broken then. Show quoted text On 2011/03/03 18:20:12, creis wrote: > On 2011/03/03 15:50:30, Paweł Hajdan Jr. wrote: > > Do not hardcode testserver URLs, it's going to break! Please read the > > net/test/test_server.h header. > > I was following what app_process did: > http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/a... Oh, it seems broken then. Show quoted text > The problem is that this is a static JSON file, so I can't just call > TestServer::GetURL. Do we have any placeholder replacement logic for JSON files > in tests? I'm not sure, I know we have tests which do substitution for HTML files served by the test server itself. Those JSON files seem to be loaded by the extensions system, so you may have to add some additional logic to handle that. If possible, please also fix the code it was copied from, it's very very fragile. Charlie Reis 2011/03/04 22:34:53 I looked closer and it turns out neither of these Show quoted text On 2011/03/03 18:24:09, Paweł Hajdan Jr. wrote: > I'm not sure, I know we have tests which do substitution for HTML files served > by the test server itself. Those JSON files seem to be loaded by the extensions > system, so you may have to add some additional logic to handle that. > > If possible, please also fix the code it was copied from, it's very very > fragile. I looked closer and it turns out neither of these tests actually relied on the web_url, so I was able to simply remove the :1337 from each of them. (The tests load pages manually, rather than launching the app's front page.) Both tests are already able to swap in the correct test server URL (see isolated_app_apitest.cc).
	11 },

	12 "isolation": [

	13 "storage"

	14 ]

	15 }

	16 }

OLD	NEW