Initial support for partitioning cookies for isolated apps.

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 487 matching lines @@
   if (spellcheck_host_.get())
     spellcheck_host_->UnsetObserver();
 
   if (default_request_context_ == request_context_)
     default_request_context_ = NULL;
 
   CleanupRequestContext(request_context_);
   CleanupRequestContext(media_request_context_);
   CleanupRequestContext(extensions_request_context_);
 
+  // Clean up all isolated app request contexts.
+  for (ChromeURLRequestContextGetterMap::iterator iter =
+           app_request_context_map_.begin();
+       iter != app_request_context_map_.end();
+       iter++) {

[willchan no longer on Chromium, 2011/01/26 23:21:52]

http://www.corp.google.com/eng/doc/cppguide.xml?external=y&showone=Preincreme...

Use preincrement here.

[Charlie Reis, 2011/03/01 21:33:11]

Done.

+    CleanupRequestContext(iter->second);
+  }
+
   // HistoryService may call into the BookmarkModel, as such we need to
   // delete HistoryService before the BookmarkModel. The destructor for
   // HistoryService will join with HistoryService's backend thread so that
   // by the time the destructor has finished we're sure it will no longer call
   // into the BookmarkModel.
   history_service_ = NULL;
   bookmark_bar_model_.reset();
 
   // FaviconService depends on HistoryServce so make sure we delete
   // HistoryService first.
@@ skipping 201 matching lines @@
       // net::URLRequestContext is constructed by the IO thread...
       NotificationService::current()->Notify(
           NotificationType::DEFAULT_REQUEST_CONTEXT_AVAILABLE,
           NotificationService::AllSources(), NotificationService::NoDetails());
     }
   }
 
   return request_context_;
 }
 
+URLRequestContextGetter* ProfileImpl::GetRequestContext(const Extension* app) {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableExperimentalAppManifests)

[Matt Perry, 2011/01/26 20:09:23]

chrome style is:
  (HasSwitch() &&
   app &&
   app->foo())

[Charlie Reis, 2011/03/01 21:33:11]

Done.

+      && app != NULL
+      && app->is_storage_isolated())
+    return GetRequestContextForIsolatedApp(app);
+
+  return GetRequestContext();
+}
+
 URLRequestContextGetter* ProfileImpl::GetRequestContextForMedia() {
   if (!media_request_context_) {
     FilePath cache_path = base_cache_path_;
     int max_size;
     GetCacheParameters(kMediaContext, &cache_path, &max_size);
 
     cache_path = GetMediaCachePath(cache_path);
     media_request_context_ =
         ChromeURLRequestContextGetter::CreateOriginalForMedia(
             this, cache_path, max_size);
@@ skipping 17 matching lines @@
     cookie_path = cookie_path.Append(chrome::kExtensionsCookieFilename);
 
     extensions_request_context_ =
         ChromeURLRequestContextGetter::CreateOriginalForExtensions(
             this, cookie_path);
   }
 
   return extensions_request_context_;
 }
 
+URLRequestContextGetter* ProfileImpl::GetRequestContextForIsolatedApp(
+    const Extension* installed_app) {
+  CHECK(installed_app);
+  std::string id = installed_app->id();
+
+  // Keep a map of request contexts, one per requested app ID.  Once created,
+  // the context will exist for the lifetime of the profile.
+  ChromeURLRequestContextGetterMap::iterator iter =
+      app_request_context_map_.find(id);
+  if (iter != app_request_context_map_.end())
+    return iter->second;
+
+  // Have to create a new context for this app.
+  FilePath cookie_path = GetPath();
+  cookie_path = cookie_path.Append(chrome::kAppStorageDirname);
+
+  // Create the directory if it doesn't yet exist.
+  if (!file_util::DirectoryExists(cookie_path))
+    file_util::CreateDirectory(cookie_path);
+  cookie_path = cookie_path.Append(installed_app->id() +
+      chrome::kAppCookiesFileExtension);
+
+  ChromeURLRequestContextGetter* context =
+      ChromeURLRequestContextGetter::CreateOriginalForIsolatedApp(
+          this, installed_app, cookie_path);
+  app_request_context_map_[id] = context;
+
+  return context;
+}
+
 void ProfileImpl::RegisterExtensionWithRequestContexts(
     const Extension* extension) {
   // AddRef to ensure the data lives until the other thread gets it. Balanced in
   // OnNewExtensions.
   extension->AddRef();
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableMethod(extension_info_map_.get(),
                         &ExtensionInfoMap::AddExtension,
                         extension));
@@ skipping 613 matching lines @@
 }
 
 PrerenderManager* ProfileImpl::GetPrerenderManager() {
   CommandLine* cl = CommandLine::ForCurrentProcess();
   if (!cl->HasSwitch(switches::kEnablePagePrerender))
     return NULL;
   if (!prerender_manager_)
     prerender_manager_ = new PrerenderManager(this);
   return prerender_manager_;
 }