Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 6201004: ARM: Implement ClassOf in the lithium arm backend. (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Implement ClassOf in the lithium arm backend. Committed: http://code.google.com/p/v8/source/detail?r=6271

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -23 lines) Patch
M src/arm/lithium-arm.h View 1 3 chunks +5 lines, -12 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 4 chunks +94 lines, -7 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 11 months ago (2011-01-11 13:32:51 UTC) #1
Søren Thygesen Gjesse
LGTM with temp2 gone. http://codereview.chromium.org/6201004/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6201004/diff/1/src/arm/lithium-codegen-arm.cc#newcode1433 src/arm/lithium-codegen-arm.cc:1433: ASSERT(!temp.is(temp2)); // But input and ...
9 years, 11 months ago (2011-01-11 13:48:13 UTC) #2
Mads Ager (chromium)
9 years, 11 months ago (2011-01-11 14:01:26 UTC) #3
Thanks. Removed temporary from LClassOfTest and use scratch0 in its place in
both ClassOfTest and ClassOfTestAndBranch.

Powered by Google App Engine
This is Rietveld 408576698