Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 62006: Add 'variants' support on Linux for COVERAGE=, PROFILE= and SYMBOLS=. (Closed)

Created:
11 years, 8 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add 'variants' support on Linux for COVERAGE=, PROFILE= and SYMBOLS=. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13115

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sgk
11 years, 8 months ago (2009-04-03 12:46:40 UTC) #1
I'll add DEPS roll of the necessary gyp update, pending your review of that CL.

Does not add support for OFFICIAL= (as discussed, that needs to be a gyp-time
option) or SHARED= (needs more extensive work than just setting additional
flags).

Powered by Google App Engine
This is Rietveld 408576698