Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6200005: Move OSExchangeData from src/app to src/ui/base/dragdrop... (Closed)

Created:
9 years, 11 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move OSExchangeData from src/app to src/ui/base/dragdrop BUG=none TEST=none TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71205

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -2365 lines) Patch
M app/app.gyp View 1 2 chunks +7 lines, -3 lines 0 comments Download
M app/app_base.gypi View 1 5 chunks +38 lines, -12 lines 0 comments Download
D app/os_exchange_data.h View 1 chunk +0 lines, -195 lines 0 comments Download
D app/os_exchange_data.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D app/os_exchange_data_provider_gtk.h View 1 chunk +0 lines, -116 lines 0 comments Download
D app/os_exchange_data_provider_gtk.cc View 1 chunk +0 lines, -244 lines 0 comments Download
D app/os_exchange_data_provider_win.h View 1 chunk +0 lines, -176 lines 0 comments Download
D app/os_exchange_data_provider_win.cc View 1 chunk +0 lines, -923 lines 0 comments Download
D app/os_exchange_data_win_unittest.cc View 1 chunk +0 lines, -373 lines 0 comments Download
M build/all.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data_unittest.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drop_target_win.cc View 7 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmark_bar_view.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bookmark_menu_controller_views.h View 3 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/bookmark_menu_controller_views.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_drag_win.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/DEPS View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + ui/base/dragdrop/os_exchange_data.h View 3 chunks +8 lines, -4 lines 0 comments Download
A + ui/base/dragdrop/os_exchange_data.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + ui/base/dragdrop/os_exchange_data_provider_gtk.h View 3 chunks +9 lines, -5 lines 0 comments Download
A + ui/base/dragdrop/os_exchange_data_provider_gtk.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
A + ui/base/dragdrop/os_exchange_data_provider_win.h View 2 chunks +9 lines, -5 lines 0 comments Download
A + ui/base/dragdrop/os_exchange_data_provider_win.cc View 3 chunks +5 lines, -3 lines 0 comments Download
A + ui/base/dragdrop/os_exchange_data_win_unittest.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M views/controls/menu/menu_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M views/controls/menu/menu_delegate.h View 1 chunk +3 lines, -1 line 0 comments Download
M views/drag_utils.h View 1 chunk +7 lines, -2 lines 0 comments Download
M views/drag_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M views/drag_utils_gtk.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M views/drag_utils_win.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M views/event.h View 1 chunk +3 lines, -0 lines 0 comments Download
M views/view.h View 1 chunk +3 lines, -1 line 0 comments Download
M views/views.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M views/widget/drop_helper.h View 1 chunk +5 lines, -2 lines 0 comments Download
M views/widget/drop_target_gtk.h View 1 chunk +5 lines, -1 line 0 comments Download
M views/widget/drop_target_gtk.cc View 1 chunk +3 lines, -1 line 0 comments Download
M views/widget/drop_target_win.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M views/widget/root_view_win.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M views/widget/widget_gtk.h View 1 chunk +7 lines, -3 lines 0 comments Download
M views/widget/widget_gtk.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
9 years, 11 months ago (2011-01-11 23:33:47 UTC) #1
brettw
9 years, 11 months ago (2011-01-11 23:39:30 UTC) #2 
Robber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698