Issue 6198005: DOMUI Prefs: Add a visual indication of the lead element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6198005: DOMUI Prefs: Add a visual indication of the lead element (Closed)

Created:
9 years, 11 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI Prefs: Add a visual indication of the lead element BUG=None TEST=Change the lead selection in DOMUI pref lists; there should be a top and bottom border. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71102

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/options_page.css	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

I followed up with Alex given your concerns from the earlier review, and we're adding ...

9 years, 11 months ago (2011-01-11 22:05:26 UTC) #1

arv (Not doing code reviews)

9 years, 11 months ago (2011-01-11 22:24:22 UTC) #2

LGTM

erik



On Tue, Jan 11, 2011 at 14:05,  <stuartmorgan@chromium.org> wrote:
> Reviewers: arv,
>
> Message:
> I followed up with Alex given your concerns from the earlier review, and
> we're
> adding a border indicator to just the lead element.
>
> Description:
> DOMUI Prefs: Add a visual indication of the lead element
>
>
> BUG=None
> TEST=Change the lead selection in DOMUI pref lists; there should be a top
> and
> bottom border.
>
> Please review this at http://codereview.chromium.org/6198005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/resources/options/options_page.css
>
>
> Index: chrome/browser/resources/options/options_page.css
> diff --git a/chrome/browser/resources/options/options_page.css
> b/chrome/browser/resources/options/options_page.css
> index
>
47447f4f20cca95c3efc897257eb9df4d27000df..6e04d759c9768cc6e8396f2944c8a1713641c97c
> 100644
> --- a/chrome/browser/resources/options/options_page.css
> +++ b/chrome/browser/resources/options/options_page.css
> @@ -378,6 +378,22 @@ list > [selected]:hover {
>   background-image: none;
>  }
>
> +list:focus > [lead],
> +list:focus > [lead][selected] {
> +  border-top: 1px solid #b2b2b2;
> +  border-bottom: 1px solid #b2b2b2;
> +}
> +
> +list:focus > [lead]:nth-child(2),
> +list:focus > [lead][selected]:nth-child(2) {
> +  border-top: 1px solid #f2f2f2;
> +}
> +
> +list:focus > [lead]:nth-last-child(2),
> +list:focus > [lead][selected]:nth-last-child(2) {
> +  border-bottom: 1px solid #f2f2f2;
> +}
> +
>  list[disabled] > [lead][selected],
>  list[disabled]:focus > [lead][selected] {
>   border: none;
>
>
>

Expand Messages | Collapse Messages