Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 6198003: Add workaround for VS2005 compile error introduced by r70933 (Closed)

Created:
9 years, 11 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
Marshall, M-A Ruel
CC:
chromium-reviews, brettw-cc_chromium.org, Nico
Visibility:
Public.

Description

Add workaround for VS2005 compile error introduced by r70933 BUG=None TEST=compiles on VS2005 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71081

Patch Set 1 #

Patch Set 2 : Fixed template line #

Patch Set 3 : Fixed windows compile failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M base/observer_list_threadsafe.h View 1 2 2 chunks +27 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+maruel and +marshall for review. Marshall, can you try it on VS2005 to make sure ...
9 years, 11 months ago (2011-01-11 03:07:55 UTC) #1
akalin
+marshall's chromium address
9 years, 11 months ago (2011-01-11 03:09:50 UTC) #2
M-A Ruel
looks fine to me
9 years, 11 months ago (2011-01-11 03:19:30 UTC) #3
Marshall
9 years, 11 months ago (2011-01-11 14:44:36 UTC) #4
Compiles on VS2005, LGTM

Powered by Google App Engine
This is Rietveld 408576698