[Mac] In ExtensionHostMac::~ExtensionHostMac, only close visible popups.

In ExtensionHostMac::~ExtensionHostMac, only close visible popups.

BUG=56340
TEST=Click on a browser action to open it. Click on the button again to close it. Click on it a third time to open, and it should open as expected.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71324

[andybons, 2011-01-12 21:22:27]

Lgtm

Thanks Robert!


Le 12 janv. 2011 à 15:24, "rsesek@chromium.org" <rsesek@chromium.org> a écrit :

> Reviewers: Andrew Bonventre (Bons),
>
> Description:
> [Mac] In ExtensionHostMac::~ExtensionHostMac, only close visible popups.
>
> BUG=56340
> TEST=Click on a browser action to open it. Click on the button again to close
> it. Click on it a third time to open, and it should open as expected.
>
> Please review this at http://codereview.chromium.org/6195004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/extensions/extension_host_mac.mm
>
>
> Index: chrome/browser/extensions/extension_host_mac.mm
> diff --git a/chrome/browser/extensions/extension_host_mac.mm
b/chrome/browser/extensions/extension_host_mac.mm
> index
67bc851831fb01b2b089851bf6433bb437e61be4..73e29fbc2c241222f6e0bb0fa61bc56edf362dda
100644
> --- a/chrome/browser/extensions/extension_host_mac.mm
> +++ b/chrome/browser/extensions/extension_host_mac.mm
> @@ -1,4 +1,4 @@
> -// Copyright (c) 2010 The Chromium Authors. All rights reserved.
> +// Copyright (c) 2011 The Chromium Authors. All rights reserved.
> // Use of this source code is governed by a BSD-style license that can be
> // found in the LICENSE file.
>
> @@ -13,7 +13,8 @@
> ExtensionHostMac::~ExtensionHostMac() {
>   // If there is a popup open for this host's extension, close it.
>   ExtensionPopupController* popup = [ExtensionPopupController popup];
> -  if (popup && [popup extensionHost]->extension() == this->extension()) {
> +  if ([[popup window] isVisible] &&
> +      [popup extensionHost]->extension() == this->extension()) {
>     InfoBubbleWindow* window = (InfoBubbleWindow*)[popup window];
>     [window setDelayOnClose:NO];
>     [popup close];
>
>