Issue 6195003: Compute an error hash for suppressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6195003: Compute an error hash for suppressions (Closed)

Created:
9 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko, Timur Iskhodzhanov

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/tools/heapcheck

Visibility:
Public.

Description

Compute an error hash for suppressions BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71161

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/heapcheck/heapcheck_test.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

please review this will allow for reporting suppressions in the buildbot output

9 years, 11 months ago (2011-01-12 10:14:53 UTC) #1

Alexander Potapenko

9 years, 11 months ago (2011-01-12 12:57:59 UTC) #2

LGTM

On Wed, Jan 12, 2011 at 1:14 PM,  <jochen@chromium.org> wrote:
> Reviewers: Alexander Potapenko, Timur Iskhodzhanov,
>
> Message:
> please review
>
> this will allow for reporting suppressions in the buildbot output
>
> Description:
> Compute an error hash for suppressions
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/6195003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/tools/heapcheck
>
> Affected files:
>  M tools/heapcheck/heapcheck_test.py
>
>
> Index: tools/heapcheck/heapcheck_test.py
> diff --git a/tools/heapcheck/heapcheck_test.py
> b/tools/heapcheck/heapcheck_test.py
> index
>
cb3a7b458ff26fe78a337b3b42a5c5078b002b25..9c1165fde48d732b7559a0456b96817b6fde3003
> 100644
> --- a/tools/heapcheck/heapcheck_test.py
> +++ b/tools/heapcheck/heapcheck_test.py
> @@ -123,7 +123,8 @@ class HeapcheckWrapper(object):
>             # Generate the suppression iff the stack contains more than one
>             # frame (otherwise it's likely to be broken)
>             if len(cur_stack) > 1:
> -              print '\nSuppression:\n{'
> +              print '\nSuppression (error hash=#%016X#):\n{' \
> +                  % (hash("".join(cur_stack)) & 0xffffffffffffffff)
>               print '   <insert_a_suppression_name_here>'
>               print '   Heapcheck:Leak'
>               for frame in cur_stack:
>
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

Expand Messages | Collapse Messages