Issue 6193005: Enable Breakpad for crashes in trusted code in Native Client on Chrome for Li...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6193005: Enable Breakpad for crashes in trusted code in Native Client on Chrome for Li... (Closed)

Created:
9 years, 11 months ago by cstefansen

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang (Do not use), agl, abarth-chromium

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Enable Breakpad for crashes in trusted code in Native Client on Chrome for Linux. This change ensures that the appropriate command line flag (SetCrashReporterCommandLine()) is set for the NaCl process and read by the NaCl main process when it starts. TEST= 0. Ensure that Native Client is DEPS'ed in at revision 4097 or higher 1. From src/ issue ./build/gyp_chromim -f make -dlinux_breakpad=1 2. Build Chromium (debug build) 3. With env. variable CHROME_HEADLESS=1 and NACL_CRASH_TEST=1 run out/Debug/chrome --enable-nacl --enable-crash-reporter 4. Visit a page that attempts to load a NaCl module, e.g., http://naclports.googlecode.com/svn/trunk/src/gallery/index.html 5. Observe that a .dmp file is created in ~/.config/chromium/Crash\ Reports/ BUG= http://code.google.com/p/nativeclient/issues/detail?id=206 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71459

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
M	chrome/app/breakpad_linux.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/nacl_host/nacl_process_host.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/nacl/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/nacl/nacl_main.cc	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM. I can't think of any reason why this shouldn't work. http://codereview.chromium.org/6193005/diff/1/chrome/app/breakpad_linux.cc File chrome/app/breakpad_linux.cc (right): ...

9 years, 11 months ago (2011-01-13 19:17:35 UTC) #1

cstefansen

9 years, 11 months ago (2011-01-13 21:56:06 UTC) #2

Thanks for the review. Updated comment as requested and fixed the lint error.

http://codereview.chromium.org/6193005/diff/1/chrome/app/breakpad_linux.cc
File chrome/app/breakpad_linux.cc (right):

http://codereview.chromium.org/6193005/diff/1/chrome/app/breakpad_linux.cc#ne...
chrome/app/breakpad_linux.cc:649: // Currently Non-Browser = Renderer and
Plugins
On 2011/01/13 19:17:35, agl wrote:
> Please update this comment.

Done.

Expand Messages | Collapse Messages