Issue 6193001: Add a note to tabs.onCreated documentation that the url might not be defined....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6193001: Add a note to tabs.onCreated documentation that the url might not be defined.... (Closed)

Created:
9 years, 11 months ago by asargent_no_longer_on_chrome

Modified:
9 years, 7 months ago

Reviewers:
kathyw

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Glen Murphy

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a note to tabs.onCreated documentation that the url might not be defined. Glen got bit by this during development of an extension, where he was expecting that the tab's url would always be defined right away. (Someone filed crbug.com/52195 about this a while back, but I had marked it as WontFix because there are legitimate reasons why the url isn't always set) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70767

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/common/extensions/api/extension_api.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/common/extensions/docs/tabs.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kathyw

9 years, 11 months ago (2011-01-07 20:06:14 UTC) #2

LGTM after you fix the URL references.

http://codereview.chromium.org/6193001/diff/1/chrome/common/extensions/api/ex...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/6193001/diff/1/chrome/common/extensions/api/ex...
chrome/common/extensions/api/extension_api.json:1321: "description": "Fires when
a tab is created. Note that the tab's url may not be set at the time this event
fires, but you can listen to onUpdated events to be notified when an url is
set.",
A couple of nitpicky comments:

url -> URL (x2)
an [url] -> a ...

(We've used "a" elsewhere, and we try to keep URL uppercase.)

Expand Messages | Collapse Messages