Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 619004: Implement tagging of profiler log event blocks. (Closed)

Created:
10 years, 10 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement tagging of profiler log event blocks. This change allows to associate integer tags with blocks of profiler log events, and repeat calls to 'ResumeProfiler' / 'PauseProfiler' in order to establsh nested (not necessary properly nested) blocks. By supporting this, we will be able to match WebInspector's CPU profiler abilities in DevTools. I also refactored some testing code. Committed: http://code.google.com/p/v8/source/detail?r=3889

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -170 lines) Patch
M include/v8.h View 1 chunk +12 lines, -4 lines 0 comments Download
M src/api.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/checks.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/debug-delay.js View 1 chunk +6 lines, -2 lines 0 comments Download
M src/log.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/log.cc View 3 chunks +42 lines, -33 lines 2 comments Download
M src/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M test/cctest/test-log.cc View 9 chunks +210 lines, -114 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
10 years, 10 months ago (2010-02-17 11:41:20 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/619004/diff/1/6 File src/log.cc (right): http://codereview.chromium.org/619004/diff/1/6#newcode1172 src/log.cc:1172: if (--cpu_profiler_nesting_ == 0) { Maybe make a ...
10 years, 10 months ago (2010-02-17 13:18:26 UTC) #2
mnaganov (inactive)
10 years, 10 months ago (2010-02-17 13:22:50 UTC) #3
http://codereview.chromium.org/619004/diff/1/6
File src/log.cc (right):

http://codereview.chromium.org/619004/diff/1/6#newcode1172
src/log.cc:1172: if (--cpu_profiler_nesting_ == 0) {
On 2010/02/17 13:18:26, Søren Gjesse wrote:
> Maybe make a note that these counters can be both positive and negative.

Done.

Powered by Google App Engine
This is Rietveld 408576698