Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 6190002: Change the hydrogen timing data to include zone allocation. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change the hydrogen timing data to include zone allocation. Committed: http://code.google.com/p/v8/source/detail?r=6249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M src/hydrogen.h View 4 chunks +12 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +17 lines, -6 lines 0 comments Download
M src/zone.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/zone.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/zone-inl.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
This adds a counter that's incremented on every zone allocation. If you think that's too ...
9 years, 11 months ago (2011-01-10 14:03:40 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-10 14:13:59 UTC) #2
LGTM

Let's see if we can measure the overhead. I'd guess that it will not make much
of a difference.

Powered by Google App Engine
This is Rietveld 408576698