Issue 6189008: GPU service respects --single-process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6189008: GPU service respects --single-process (Closed)

Created:
9 years, 11 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GPU service now runs on new thread in browser process when --single-process is specified. TEST=try BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71359

Patch Set 1 : '' #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -52 lines)			Patch
M	chrome/browser/gpu_process_host.cc	View	1	3 chunks	+77 lines, -34 lines	0 comments	Download
M	chrome/gpu/gpu_channel.h	View		2 chunks	+12 lines, -1 line	1 comment	Download
M	chrome/gpu/gpu_channel.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/gpu/gpu_command_buffer_stub.cc	View		7 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/gpu/gpu_main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/gpu/gpu_thread.h	View		3 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/gpu/gpu_thread.cc	View		4 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

9 years, 11 months ago (2011-01-12 23:13:56 UTC) #2

LGTM. Surprising how small this CL is.

http://codereview.chromium.org/6189008/diff/17001/chrome/gpu/gpu_channel.h
File chrome/gpu/gpu_channel.h (right):

http://codereview.chromium.org/6189008/diff/17001/chrome/gpu/gpu_channel.h#ne...
chrome/gpu/gpu_channel.h:94: // GpuThreadss destroy all the GpuChannels that
they own when they
GpuThreadss -> GpuThreads

Expand Messages | Collapse Messages