Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 6188004: Remove test_timeout_ms and fix all the callers. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove test_timeout_ms and fix all the callers. (This was a TODO for phajdan.jr). BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -25 lines) Patch
M chrome/browser/dom_ui/bookmarks_ui_uitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/page_cycler/page_cycler_test.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/selenium/selenium_test.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/ui/dom_checker_uitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/ui/dromaeo_benchmark_uitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/ui/sunspider_uitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_test.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/test/ui/v8_benchmark_uitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/url_fetch_test/url_fetch_test.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-12 03:13:21 UTC) #1
Paweł Hajdan Jr.
9 years, 11 months ago (2011-01-12 09:02:59 UTC) #2
LGTM, thank you!

Powered by Google App Engine
This is Rietveld 408576698