Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 6186007: Update our yasm copy to yasm 1.1.0 (Part 2: Chromium side).... (Closed)

Created:
9 years, 11 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
fbarchard, fbarchard1
CC:
chromium-reviews
Visibility:
Public.

Description

Update our yasm copy to yasm 1.1.0 (the Chromium side). This change add a new file added by yasm 1.1.0 to the GYP file for yasm. BUG=64640 TEST=build chromium without errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71305

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/yasm/yasm.gyp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hironori Bono
Greetings, Since this change requires to pull <http://codereview.chromium.org/6170009/>, it may be better to include a ...
9 years, 11 months ago (2011-01-12 08:09:50 UTC) #1
fbarchard1
LGTM with nit DEPS is probably not warranted. Once we get things building with yasm, ...
9 years, 11 months ago (2011-01-12 16:43:51 UTC) #2
Hironori Bono
Greetings, Thank you for your review. The trybot results of this change show we can ...
9 years, 11 months ago (2011-01-13 07:57:20 UTC) #3
fbarchard1
9 years, 11 months ago (2011-01-13 08:33:38 UTC) #4
nice

On Wed, Jan 12, 2011 at 11:57 PM, <hbono@chromium.org> wrote:

> Greetings,
>
> Thank you for your review. The trybot results of this change show we can
> build
> Chromium with yasm 1.1 successfully. :)
>
> Regards,
>
> Hironori Bono
>
>
>
> http://codereview.chromium.org/6186007/diff/1/third_party/yasm/yasm.gyp
> File third_party/yasm/yasm.gyp (right):
>
>
>
http://codereview.chromium.org/6186007/diff/1/third_party/yasm/yasm.gyp#newcode1
> third_party/yasm/yasm.gyp:1: # Copyright (c) 2009 The Chromium Authors.
> All rights reserved.
> On 2011/01/12 16:43:51, fbarchard1 wrote:
>
>> update to 2011
>>
>
> Done.
>
>
> http://codereview.chromium.org/6186007/
>

Powered by Google App Engine
This is Rietveld 408576698