NSS: don't set environment variables when multi-threaded.

chrome/app/chrome_main.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/app_paths.h"
 #include "app/app_switches.h"
 #include "app/resource_bundle.h"
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/i18n/icu_util.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
 #include "base/message_loop.h"
 #include "base/metrics/stats_counters.h"
 #include "base/metrics/stats_table.h"
+#include "base/nss_util.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/diagnostics/diagnostics_main.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/renderer_host/render_process_host.h"
@@ skipping 681 matching lines @@
     if (!base::debug::BeingDebugged())
       signal(SIGINT, SIG_IGN);
 #endif
   }
   SetupCRT(command_line);
 
   // Initialize the Chrome path provider.
   app::RegisterPathProvider();
   chrome::RegisterPathProvider();
 
+  base::EarlyNSSInit();

[wtc, 2011/01/13 00:07:02]

Nit: since EarlyNSSInit doesn't use the Chrome path provider, it seems
that we can call EarlyNSSInit earlier, immediately after the SecupCRT call
at line 712.

At least, we should not call EarlyNSSInit in the middle of the code block
that sets up the Chrome path provider (lines 714-724).

+
   // Notice a user data directory override if any
   const FilePath user_data_dir =
       command_line.GetSwitchValuePath(switches::kUserDataDir);
   if (!user_data_dir.empty())
     CHECK(PathService::Override(chrome::DIR_USER_DATA, user_data_dir));
 
 #if defined(OS_MACOSX)
   // TODO(mark): Right now, InitCrashReporter() needs to be called after
   // CommandLine::Init() and chrome::RegisterPathProvider().  Ideally, Breakpad
   // initialization could occur sooner, preferably even before the framework
@@ skipping 186 matching lines @@
 
   int exit_code = RunNamedProcessTypeMain(process_type, main_params);
 
   if (SubprocessNeedsResourceBundle(process_type))
     ResourceBundle::CleanupSharedInstance();
 
   LowLevelShutdown();
 
   return exit_code;
 }