chrome/browser/sync/notifier/server_notifier_thread.cc - Issue 6182004: [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/notifier/server_notifier_thread.cc

Issue 6182004: [SYNC] Refactor SyncSourceInfo and add support in chrome invalidation client ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Comments. Also removed unnecessary LOG(WARNING). Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/notifier/chrome_invalidation_client.cc ('K') | « chrome/browser/sync/notifier/server_notifier_thread.h ('k') | chrome/browser/sync/sessions/sync_session.h » ('j') | chrome/browser/sync/sessions/sync_session.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/notifier/server_notifier_thread.cc

===================================================================

--- chrome/browser/sync/notifier/server_notifier_thread.cc (revision 71061)

+++ chrome/browser/sync/notifier/server_notifier_thread.cc (working copy)

@@ -64,7 +64,9 @@

"used";

}

-void ServerNotifierThread::OnInvalidate(syncable::ModelType model_type) {

+void ServerNotifierThread::OnInvalidate(

+ syncable::ModelType model_type,

+ const std::string& payload) {

DCHECK_EQ(MessageLoop::current(), worker_message_loop());

// TODO(akalin): This is a hack to make new sync data types work

// with server-issued notifications. Remove this when it's not

@@ -75,7 +77,8 @@

syncable::ModelTypeBitSet model_types;

model_types[model_type] = true;

IncomingNotificationData notification_data;

- notification_data.service_specific_data = model_types.to_string();

+ notification_data.service_url = model_types.to_string();

+ notification_data.service_specific_data = payload;

observers_->Notify(&Observer::OnIncomingNotification, notification_data);

}