Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 6181005: Remove workaround for gyp issue 102 and use libjpeg_turbo on Linux.... (Closed)

Created:
9 years, 11 months ago by Craig
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove workaround for gyp issue 102 and use libjpeg_turbo on Linux. Note that you still need use_libjpeg_turbo=1 to activate for now. BUG=31427, 48789 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M libjpeg.gyp View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Craig
This patch was sent to the tryservers on linux here: http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/7925/ (that patch included a ...
9 years, 11 months ago (2011-01-12 12:46:20 UTC) #1
Hironori Bono
LGTM. (It seems I need to refactor this GYP file, though.) Thank you so much ...
9 years, 11 months ago (2011-01-13 00:32:21 UTC) #2
Craig
9 years, 11 months ago (2011-01-13 16:34:25 UTC) #3
On 2011/01/13 00:32:21, hbono wrote:
> LGTM. (It seems I need to refactor this GYP file, though.)
> Thank you so much for your change.

No problem :)

I see the gyp DEPS roll was reverted again (the commit rolled nacl and breakpad
too and the breakpad change broke something). I'll put together a change later
to roll DEPS for gyp and libjpeg_turbo at the same time to pick up the change
here.

Powered by Google App Engine
This is Rietveld 408576698