Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/x64/virtual-frame-x64.cc

Issue 618006: Remove obsolete bug TODO (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1015 matching lines...) Expand 10 before | Expand all | Expand 10 after
1026 PrepareForCall(2, 0); // Two stack args, neither callee-dropped. 1026 PrepareForCall(2, 0); // Two stack args, neither callee-dropped.
1027 return RawCallCodeObject(ic, mode); 1027 return RawCallCodeObject(ic, mode);
1028 } 1028 }
1029 1029
1030 1030
1031 Result VirtualFrame::CallKeyedStoreIC() { 1031 Result VirtualFrame::CallKeyedStoreIC() {
1032 // Value, key, and receiver are on the top of the frame. The IC 1032 // Value, key, and receiver are on the top of the frame. The IC
1033 // expects value in rax and key and receiver on the stack. It does 1033 // expects value in rax and key and receiver on the stack. It does
1034 // not drop the key and receiver. 1034 // not drop the key and receiver.
1035 Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize)); 1035 Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
1036 // TODO(1222589): Make the IC grab the values from the stack.
1037 Result value = Pop(); 1036 Result value = Pop();
1038 PrepareForCall(2, 0); // Two stack args, neither callee-dropped. 1037 PrepareForCall(2, 0); // Two stack args, neither callee-dropped.
1039 value.ToRegister(rax); 1038 value.ToRegister(rax);
1040 value.Unuse(); 1039 value.Unuse();
1041 return RawCallCodeObject(ic, RelocInfo::CODE_TARGET); 1040 return RawCallCodeObject(ic, RelocInfo::CODE_TARGET);
1042 } 1041 }
1043 1042
1044 1043
1045 Result VirtualFrame::CallCallIC(RelocInfo::Mode mode, 1044 Result VirtualFrame::CallCallIC(RelocInfo::Mode mode,
1046 int arg_count, 1045 int arg_count,
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
1134 // Grow the expression stack by handler size less one (the return 1133 // Grow the expression stack by handler size less one (the return
1135 // address is already pushed by a call instruction). 1134 // address is already pushed by a call instruction).
1136 Adjust(kHandlerSize - 1); 1135 Adjust(kHandlerSize - 1);
1137 __ PushTryHandler(IN_JAVASCRIPT, type); 1136 __ PushTryHandler(IN_JAVASCRIPT, type);
1138 } 1137 }
1139 1138
1140 1139
1141 #undef __ 1140 #undef __
1142 1141
1143 } } // namespace v8::internal 1142 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698