Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 618006: Remove obsolete bug TODO (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/ia32/virtual-frame-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5772 matching lines...) Expand 10 before | Expand all | Expand 10 after
5783 } 5783 }
5784 5784
5785 } else { 5785 } else {
5786 Load(node->expression()); 5786 Load(node->expression());
5787 bool overwrite = 5787 bool overwrite =
5788 (node->expression()->AsBinaryOperation() != NULL && 5788 (node->expression()->AsBinaryOperation() != NULL &&
5789 node->expression()->AsBinaryOperation()->ResultOverwriteAllowed()); 5789 node->expression()->AsBinaryOperation()->ResultOverwriteAllowed());
5790 switch (op) { 5790 switch (op) {
5791 case Token::SUB: { 5791 case Token::SUB: {
5792 GenericUnaryOpStub stub(Token::SUB, overwrite); 5792 GenericUnaryOpStub stub(Token::SUB, overwrite);
5793 // TODO(1222589): remove dependency of TOS being cached inside stub
5794 Result operand = frame_->Pop(); 5793 Result operand = frame_->Pop();
5795 Result answer = frame_->CallStub(&stub, &operand); 5794 Result answer = frame_->CallStub(&stub, &operand);
5796 frame_->Push(&answer); 5795 frame_->Push(&answer);
5797 break; 5796 break;
5798 } 5797 }
5799 5798
5800 case Token::BIT_NOT: { 5799 case Token::BIT_NOT: {
5801 // Smi check. 5800 // Smi check.
5802 JumpTarget smi_label; 5801 JumpTarget smi_label;
5803 JumpTarget continue_label; 5802 JumpTarget continue_label;
(...skipping 4818 matching lines...) Expand 10 before | Expand all | Expand 10 after
10622 10621
10623 // Call the runtime; it returns -1 (less), 0 (equal), or 1 (greater) 10622 // Call the runtime; it returns -1 (less), 0 (equal), or 1 (greater)
10624 // tagged as a small integer. 10623 // tagged as a small integer.
10625 __ bind(&runtime); 10624 __ bind(&runtime);
10626 __ TailCallRuntime(ExternalReference(Runtime::kStringCompare), 2, 1); 10625 __ TailCallRuntime(ExternalReference(Runtime::kStringCompare), 2, 1);
10627 } 10626 }
10628 10627
10629 #undef __ 10628 #undef __
10630 10629
10631 } } // namespace v8::internal 10630 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/ia32/virtual-frame-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698