Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 618006: Remove obsolete bug TODO (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4393 matching lines...) Expand 10 before | Expand all | Expand 10 after
4404 } 4404 }
4405 4405
4406 case KEYED: { 4406 case KEYED: {
4407 Comment cmnt(masm, "[ Store to keyed Property"); 4407 Comment cmnt(masm, "[ Store to keyed Property");
4408 Property* property = expression_->AsProperty(); 4408 Property* property = expression_->AsProperty();
4409 ASSERT(property != NULL); 4409 ASSERT(property != NULL);
4410 cgen_->CodeForSourcePosition(property->position()); 4410 cgen_->CodeForSourcePosition(property->position());
4411 4411
4412 // Call IC code. 4412 // Call IC code.
4413 Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize)); 4413 Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
4414 // TODO(1222589): Make the IC grab the values from the stack.
4415 frame->EmitPop(r0); // value 4414 frame->EmitPop(r0); // value
4416 frame->CallCodeObject(ic, RelocInfo::CODE_TARGET, 0); 4415 frame->CallCodeObject(ic, RelocInfo::CODE_TARGET, 0);
4417 frame->EmitPush(r0); 4416 frame->EmitPush(r0);
4418 cgen_->UnloadReference(this); 4417 cgen_->UnloadReference(this);
4419 break; 4418 break;
4420 } 4419 }
4421 4420
4422 default: 4421 default:
4423 UNREACHABLE(); 4422 UNREACHABLE();
4424 } 4423 }
(...skipping 3190 matching lines...) Expand 10 before | Expand all | Expand 10 after
7615 7614
7616 // Just jump to runtime to add the two strings. 7615 // Just jump to runtime to add the two strings.
7617 __ bind(&string_add_runtime); 7616 __ bind(&string_add_runtime);
7618 __ TailCallRuntime(ExternalReference(Runtime::kStringAdd), 2, 1); 7617 __ TailCallRuntime(ExternalReference(Runtime::kStringAdd), 2, 1);
7619 } 7618 }
7620 7619
7621 7620
7622 #undef __ 7621 #undef __
7623 7622
7624 } } // namespace v8::internal 7623 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698