Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 6179002: Added group policy for disabling all client-side 3D APIs in Chromium ... (Closed)

Created:
9 years, 11 months ago by jschuh
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Added group policy for disabling all client-side 3D APIs in Chromium (in particular, WebGL and Pepper 3D). This has been hooked up through a new command-line argument (--disable-3d-apis) orthogonal to the existing ones, so that further changes to those command line arguments will not accidentally regress the group policy support. Tested in the following ways: - Verified that --disable-3d-apis disables WebGL and Pepper 3D support on Mac OS X. - Verified that specifying the Disable3DAPIs policy via a JSON file disables WebGL on Linux. - Ran unit_tests and verified that there were no failures introduced. BUG=64806 TEST=ConfigurationPolicyPrefStoreBooleanTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71072

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
M chrome/app/policy/policy_templates.grd View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/app/policy/policy_templates.json View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
MM chrome/browser/policy/configuration_policy_store_interface.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/policy_constants.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/policy_constants.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/sandbox_init_wrapper_mac.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/sandbox_policy.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/worker/worker_thread.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jschuh
This is the m9 merge patch. The only significant change should be the removal of ...
9 years, 11 months ago (2011-01-08 00:00:54 UTC) #1
Ken Russell (switch to Gerrit)
Thanks for doing this backport, but there's a major problem: http://codereview.chromium.org/6179002/diff/1/chrome/browser/renderer_host/browser_render_process_host.cc File chrome/browser/renderer_host/browser_render_process_host.cc (right): http://codereview.chromium.org/6179002/diff/1/chrome/browser/renderer_host/browser_render_process_host.cc#newcode641 ...
9 years, 11 months ago (2011-01-08 00:10:43 UTC) #2
jschuh
Sorry, stupid oversight on my part. I just didn't see that the second chunk of ...
9 years, 11 months ago (2011-01-08 00:22:50 UTC) #3
Ken Russell (switch to Gerrit)
On 2011/01/08 00:22:50, Justin Schuh wrote: > Sorry, stupid oversight on my part. I just ...
9 years, 11 months ago (2011-01-08 01:47:09 UTC) #4
Ken Russell (switch to Gerrit)
The new patch LGTM as long as the support for the flag has been tested ...
9 years, 11 months ago (2011-01-08 01:48:04 UTC) #5
jschuh
9 years, 11 months ago (2011-01-11 20:05:00 UTC) #6
Ran the tests and checked the switch manually. Everything is good and I just
landed on the branch.

Powered by Google App Engine
This is Rietveld 408576698