Issue 6177002: Flags: Enable Tabbed Options by default.

Issue 6177002: Flags: Enable Tabbed Options by default. (Closed)

Created:
9 years, 11 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
csilv, stuartmorgan, Evan Stade

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Flags: Enable Tabbed Options by default. BUG=59972 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70796

Patch Set 5 : Line length fix. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -46 lines)			Patch
M	chrome/browser/about_flags.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_factory.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/options/options_ui_uitest.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2 3	9 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/browser_navigator_browsertest.cc	View	1 2 3 4	2 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM We don't need to do anything with native pref window tests, do we? http://codereview.chromium.org/6177002/diff/1/chrome/common/chrome_switches.cc ...

9 years, 11 months ago (2011-01-07 19:12:34 UTC) #4

James Hawkins

http://codereview.chromium.org/6177002/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/6177002/diff/1/chrome/common/chrome_switches.cc#newcode348 chrome/common/chrome_switches.cc:348: // Disable tabbed options, ie: DOMUI version of options ...

9 years, 11 months ago (2011-01-07 19:16:09 UTC) #5

csilv

We also need to update a reference in app_controller_mac.mm:1092. http://codereview.chromium.org/6177002/diff/7001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): http://codereview.chromium.org/6177002/diff/7001/chrome/common/chrome_switches.h#newcode173 chrome/common/chrome_switches.h:173: ...

9 years, 11 months ago (2011-01-07 20:42:23 UTC) #6

James Hawkins

Removed mac reference. http://codereview.chromium.org/6177002/diff/7001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): http://codereview.chromium.org/6177002/diff/7001/chrome/common/chrome_switches.h#newcode173 chrome/common/chrome_switches.h:173: extern const char kEnableTabbedOptions[]; On 2011/01/07 ...

9 years, 11 months ago (2011-01-07 20:58:16 UTC) #7

LGTM

Expand Messages | Collapse Messages