Issue 6176005: Support int-typed policies in policy template generator

Issue 6176005: Support int-typed policies in policy template generator (Closed)

Created:
9 years, 11 months ago by Jakob Kummerow

Modified:
9 years, 6 months ago

Reviewers:
gfeher

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr., danno, Mattias Nissler (ping if slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Support int-typed policies in policy template generator Also fix bug 69054 (reg_writer erroneously outputs integers as decimal values). BUG=68843, 69054 TEST=tools/grit/grit/format/policy_templates/*_unittest.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71316

Patch Set 1 #

Total comments: 2

Patch Set 2 : include fix for bug 69054 #

Total comments: 2

Patch Set 3 : address comment #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+284 lines, -40 lines)			Patch
M	chrome/app/policy/policy_templates.json	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/adm_writer.py	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/adm_writer_unittest.py	View		7 chunks	+54 lines, -7 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/adml_writer.py	View		3 chunks	+7 lines, -2 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/adml_writer_unittest.py	View		3 chunks	+34 lines, -2 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/admx_writer.py	View	1 2	3 chunks	+15 lines, -1 line	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/admx_writer_unittest.py	View		3 chunks	+24 lines, -2 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/doc_writer.py	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py	View	1 2	2 chunks	+15 lines, -1 line	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/json_writer.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py	View		3 chunks	+29 lines, -2 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/plist_strings_writer_unittest.py	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/plist_writer.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/plist_writer_unittest.py	View		8 chunks	+56 lines, -7 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/reg_writer.py	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py	View	1 2	3 chunks	+30 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

gfeher

Looks overall good, I'll go through it tomorrow more carefully. Now I'll just point you ...

9 years, 11 months ago (2011-01-10 20:56:33 UTC) #2

Jakob Kummerow

http://codereview.chromium.org/6176005/diff/1/tools/grit/grit/format/policy_templates/writers/reg_writer.py File tools/grit/grit/format/policy_templates/writers/reg_writer.py (right): http://codereview.chromium.org/6176005/diff/1/tools/grit/grit/format/policy_templates/writers/reg_writer.py#newcode60 tools/grit/grit/format/policy_templates/writers/reg_writer.py:60: example_value_str = 'dword:%d' % example_value On 2011/01/10 20:56:33, gfeher ...

9 years, 11 months ago (2011-01-11 08:47:27 UTC) #3

gfeher

LGTM with one more issue. Thanks for fixing my drive-by bug. http://codereview.chromium.org/6176005/diff/4001/tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py File tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py (right): ...

9 years, 11 months ago (2011-01-11 15:15:25 UTC) #4

Jakob Kummerow

9 years, 11 months ago (2011-01-11 15:37:25 UTC) #5

I'll wait for danno's CL 5958014, then I'll land this.

http://codereview.chromium.org/6176005/diff/4001/tools/grit/grit/format/polic...
File tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py
(right):

http://codereview.chromium.org/6176005/diff/4001/tools/grit/grit/format/polic...
tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py:324:
'example_value': 5
On 2011/01/11 15:15:25, gfeher wrote:
> Please test with a double-digit number to verify conversion to hex.

Done.

Expand Messages | Collapse Messages