Issue 6175006: touch: Set the timestamp for the touchevent.

Issue 6175006: touch: Set the timestamp for the touchevent. (Closed)

Created:
9 years, 11 months ago by sadrul

Modified:
9 years, 6 months ago

Reviewers:
rjkroege

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

touch: Set the timestamp for the touchevent. BUG=touchy clicks don't work TEST=touchy clicks work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71348

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_views.cc	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rjkroege

http://codereview.chromium.org/6175006/diff/1/chrome/browser/renderer_host/render_widget_host_view_views.cc File chrome/browser/renderer_host/render_widget_host_view_views.cc (right): http://codereview.chromium.org/6175006/diff/1/chrome/browser/renderer_host/render_widget_host_view_views.cc#newcode724 chrome/browser/renderer_host/render_widget_host_view_views.cc:724: touch_event_.timeStampSeconds = base::Time::Now().ToDoubleT(); I would prefer if you used ...

9 years, 11 months ago (2011-01-12 19:06:26 UTC) #2

sadrul

9 years, 11 months ago (2011-01-12 19:44:55 UTC) #3

rjkroege

9 years, 11 months ago (2011-01-12 20:59:42 UTC) #4

On 2011/01/12 19:44:55, sadrul wrote:
>
http://codereview.chromium.org/6175006/diff/1/chrome/browser/renderer_host/re...
> File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):
> 
>
http://codereview.chromium.org/6175006/diff/1/chrome/browser/renderer_host/re...
> chrome/browser/renderer_host/render_widget_host_view_views.cc:724:
> touch_event_.timeStampSeconds = base::Time::Now().ToDoubleT();
> On 2011/01/12 19:06:26, rjkroege wrote:
> > I would prefer if you used the time from the originating X event. Would it
be
> > hard?
> 
> At the moment, this doesn't work, since |views::Event::time_stamp_| is never
set
> in non-Windows.

OK. but given that you wrote the code to push the touch events into the views
stack, maybe it could?

Anyway: LGTM for this with the proviso that you take a todo for the above.

Expand Messages | Collapse Messages