Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Issue 6175002: views: Implement NativeTableGtk::GetColumnWidth method. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Jay Civelli, oshima
CC:
chromium-reviews, Evan Stade, Evan Martin
Visibility:
Public.

Description

views: Implement NativeTableGtk::GetColumnWidth method. BUG=None TEST=export GYP_DEFINES="toolkit_views" && gclient runhooks && make -j4 -k views_examples out/Debug/views_examples Go to the table tab. Click on one of the checkboxes, you shouldn't see an ERROR for this method. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M views/controls/table/native_table_gtk.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-09 13:25:01 UTC) #1
evanm
Can you find the author of this code (svn blame or git blame) and ask ...
9 years, 11 months ago (2011-01-09 18:03:59 UTC) #2
tfarina
On 2011/01/09 18:03:59, evanm wrote: > Can you find the author of this code (svn ...
9 years, 11 months ago (2011-01-09 18:14:29 UTC) #3
Evan Stade
oshima or sky
9 years, 11 months ago (2011-01-10 18:42:21 UTC) #4
tfarina
Oshima, could you take a look instead?
9 years, 11 months ago (2011-01-10 18:44:11 UTC) #5
oshima
On 2011/01/10 18:44:11, tfarina wrote: > Oshima, could you take a look instead? Jay is ...
9 years, 11 months ago (2011-01-10 18:58:18 UTC) #6
tfarina
Jay, could you review this to me?
9 years, 11 months ago (2011-01-11 17:20:41 UTC) #7
Jay Civelli
9 years, 11 months ago (2011-01-11 20:14:19 UTC) #8
LGTM

On Tue, Jan 11, 2011 at 9:20 AM,  <tfarina@chromium.org> wrote:
> Jay, could you review this to me?
>
> http://codereview.chromium.org/6175002/
>

Powered by Google App Engine
This is Rietveld 408576698