Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: chrome/browser/resources/options/font_settings.html

Issue 6174009: Tidy up <select>s in tabbed options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't anonymize Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/font_settings.html
diff --git a/chrome/browser/resources/options/font_settings.html b/chrome/browser/resources/options/font_settings.html
index 0967b1e260b97ad7597f4e030edc555bea7da283..411ca6658cded163e90ae39f21da97b0b203a6f3 100644
--- a/chrome/browser/resources/options/font_settings.html
+++ b/chrome/browser/resources/options/font_settings.html
@@ -6,6 +6,7 @@
<div>
<select class="font-input" i18n-options="fontSettingsFontList"
pref="webkit.webprefs.serif_font_family"
+ dataType="string"
metric="Options_ChangeSerifFont"></select>
</div>
<div>
@@ -26,6 +27,7 @@
<div>
<select class="font-input" i18n-options="fontSettingsFontList"
pref="webkit.webprefs.fixed_font_family"
+ dataType="string"
metric="Options_ChangeFixedFont"></select>
</div>
<div>
@@ -60,8 +62,9 @@
<div class="font-input-div">
<div>
<select class="font-input" i18n-options="fontSettingsEncodingList"
- pref="intl.charset_default" metric="Options_ChangeFontEncoding">
- </select>
+ pref="intl.charset_default"
+ dataType="string"
+ metric="Options_ChangeFontEncoding"></select>
</div>
</div>
</section>

Powered by Google App Engine
This is Rietveld 408576698